[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] configure: propagate --extra-cflags and --extra-ldflags
Re: [PATCH 3/4] configure: propagate --extra-cflags and --extra-ldflags to meson compile tests
Mon, 8 Nov 2021 12:07:58 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0
On 11/8/21 10:11, Thomas Huth wrote:
+ EXTRA_CXXFLAGS="$EXTRA_CXXFLAGS $optarg"
I'd rather drop that EXTRA_CXXFLAGS line here - I think that calls for
trouble otherwise if a user is trying to add a C compiler option that is
not supported in C++ mode.
If the users have some options that need to be passed to both, C and
C++, they should simply use --extra-cxxflags in addition instead.
True, but that is needed to preserve previous behavior, where
QEMU_CXXFLAGS is initialized with QEMU_CFLAGS in update_cxxflags.
update_cxxflags does not do any filtering either, except for some -W
options that shouldn't be in --extra-cflags. So (apart from those -W
options) a C-only option wouldn't have worked before with