[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/6] target/i386/sev: Rephrase error message when no hashe
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v2 3/6] target/i386/sev: Rephrase error message when no hashes table in guest firmware |
Date: |
Mon, 8 Nov 2021 13:53:37 +0000 |
User-agent: |
Mutt/2.0.7 (2021-05-04) |
On Mon, Nov 08, 2021 at 01:48:37PM +0000, Dov Murik wrote:
> Signed-off-by: Dov Murik <dovmurik@linux.ibm.com>
> ---
> target/i386/sev.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/target/i386/sev.c b/target/i386/sev.c
> index e3abbeef68..c71d23654f 100644
> --- a/target/i386/sev.c
> +++ b/target/i386/sev.c
> @@ -1232,7 +1232,8 @@ bool
> sev_add_kernel_loader_hashes(SevKernelLoaderContext *ctx, Error **errp)
> }
>
> if (!pc_system_ovmf_table_find(SEV_HASH_TABLE_RV_GUID, &data, NULL)) {
> - error_setg(errp, "SEV: kernel specified but OVMF has no hash table
> guid");
> + error_setg(errp, "SEV: -kernel specified but guest firmware "
> + "has no hashes table GUID");
Don't refer to "-kernel" as that's just one way to specifying it. The
user might have used
-machine ....,kernel=/path/to/vmlinux
Simply "kernel" as the original text has, is fine.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 0/6] SEV: add kernel-hashes=on for measured -kernel launch, Dov Murik, 2021/11/08
- [PATCH v2 4/6] target/i386/sev: Fail when invalid hashes table area detected, Dov Murik, 2021/11/08
- [PATCH v2 3/6] target/i386/sev: Rephrase error message when no hashes table in guest firmware, Dov Murik, 2021/11/08
- Re: [PATCH v2 3/6] target/i386/sev: Rephrase error message when no hashes table in guest firmware,
Daniel P . Berrangé <=
- [PATCH v2 5/6] target/i386/sev: Perform padding calculations at compile-time, Dov Murik, 2021/11/08
- [PATCH v2 1/6] qapi/qom, target/i386: sev-guest: Introduce kernel-hashes=on|off option, Dov Murik, 2021/11/08
- Re: [PATCH v2 1/6] qapi/qom,target/i386: sev-guest: Introduce kernel-hashes=on|off option, Daniel P . Berrangé, 2021/11/11
[PATCH v2 2/6] target/i386/sev: Add kernel hashes only if sev-guest.kernel-hashes=on, Dov Murik, 2021/11/08