qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 34/37] bsd-user/arm/signal.c: arm set_mcontext


From: Richard Henderson
Subject: Re: [PATCH v5 34/37] bsd-user/arm/signal.c: arm set_mcontext
Date: Mon, 8 Nov 2021 16:42:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/8/21 4:51 AM, Warner Losh wrote:
+    env->regs[15] = tswap32(gr[TARGET_REG_PC] & ~mask);

Oops, one more buglet: the mask should be outside the tswap.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]