Re: [PATCH] pci-host: Allow extended config space access for PowerNV PHB4 model

[Cédric Le Goater]

On 11/9/21 16:51, Frederic Barrat wrote:
> On 09/11/2021 15:50, Christophe Lombard wrote:
> > The PCIe extended configuration space on the device is not currently
> > accessible to the host. if by default,  it is still inaccessible for
> > conventional for PCIe buses, add the current flag
> > PCI_BUS_EXTENDED_CONFIG_SPACE on the root bus permits PCI-E extended
> > config space access.

For the record, this is coming from an experiment of plugging a
CXL device on a QEMU PowerNV POWER10 machine (baremetal). Only
minor changes (64 bits ops) were required to get it working.
 
I wonder where are with the CXL models ?

> > Signed-off-by: Christophe Lombard <clombard@linux.vnet.ibm.com>
> > ---
>
>
> FWIW, looks good to me
> Reviewed-by: Frederic Barrat <fbarrat@linux.ibm.com>



Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.


> >   hw/pci-host/pnv_phb4.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/hw/pci-host/pnv_phb4.c b/hw/pci-host/pnv_phb4.c
> > index 5c375a9f28..40b793201a 100644
> > --- a/hw/pci-host/pnv_phb4.c
> > +++ b/hw/pci-host/pnv_phb4.c
> > @@ -1205,6 +1205,7 @@ static void pnv_phb4_realize(DeviceState *dev, Error 
> > **errp)
> >                                        &phb->pci_mmio, &phb->pci_io,
> >                                        0, 4, TYPE_PNV_PHB4_ROOT_BUS);
> >       pci_setup_iommu(pci->bus, pnv_phb4_dma_iommu, phb);
> > +    pci->bus->flags |= PCI_BUS_EXTENDED_CONFIG_SPACE;
> >       /* Add a single Root port */
> >       qdev_prop_set_uint8(DEVICE(&phb->root), "chassis", phb->chip_id);