Re: [PATCH 0/4] linux-user: Fix getdents alignment issues (#704)

[Richard Henderson]

On 11/9/21 5:46 PM, Warner Losh wrote:
> > On Nov 7, 2021, at 5:48 AM, Richard Henderson <richard.henderson@linaro.org> 
> > wrote:
> >
> > There are a number of alignement issues flagged up by clang,
> > this attempts to fix only one of them: getdents.
>
> Does it make sense to have size asserts for these types? That would catch the 
> alignment issues and are cheap to maintain since ABI sizes should never change…

Well, the size of getdents64 doesn't change; it merely lands at a different memory offset. 
 But we've now told the compiler about it.


r~