Re: [PATCH v2 13/14] target/riscv: Don't save pc when exception return

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 13/14] target/riscv: Don't save pc when exception return

From:	Richard Henderson
Subject:	Re: [PATCH v2 13/14] target/riscv: Don't save pc when exception return
Date:	Wed, 10 Nov 2021 12:25:54 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0

On 11/10/21 8:04 AM, LIU Zhiwei wrote:

As pc will be written by the xepc in exception return, just ignore
pc in translation.

Signed-off-by: LIU Zhiwei <zhiwei_liu@c-sky.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
  target/riscv/helper.h                          | 4 ++--
  target/riscv/insn_trans/trans_privileged.c.inc | 7 ++-----
  target/riscv/op_helper.c                       | 4 ++--
  3 files changed, 6 insertions(+), 9 deletions(-)

This should be ordered before patch 1, so that it does not appear that you have missedplaces that should use gen_set_pc.

r~

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 10/14] target/riscv: Adjust vector address with mask, (continued)
- [PATCH v2 11/14] target/riscv: Adjust scalar reg in vector with XLEN, LIU Zhiwei, 2021/11/10
  - Re: [PATCH v2 11/14] target/riscv: Adjust scalar reg in vector with XLEN, Richard Henderson, 2021/11/10
- [PATCH v2 12/14] target/riscv: Split out the vill from vtype, LIU Zhiwei, 2021/11/10
  - Re: [PATCH v2 12/14] target/riscv: Split out the vill from vtype, Richard Henderson, 2021/11/10
    - Re: [PATCH v2 12/14] target/riscv: Split out the vill from vtype, LIU Zhiwei, 2021/11/10
    - Re: [PATCH v2 12/14] target/riscv: Split out the vill from vtype, Richard Henderson, 2021/11/10
- [PATCH v2 13/14] target/riscv: Don't save pc when exception return, LIU Zhiwei, 2021/11/10
  - Re: [PATCH v2 13/14] target/riscv: Don't save pc when exception return, Richard Henderson <=
- [PATCH v2 14/14] target/riscv: Enable uxl field write, LIU Zhiwei, 2021/11/10
  - Re: [PATCH v2 14/14] target/riscv: Enable uxl field write, Richard Henderson, 2021/11/10
    - Re: [PATCH v2 14/14] target/riscv: Enable uxl field write, LIU Zhiwei, 2021/11/10
    - Re: [PATCH v2 14/14] target/riscv: Enable uxl field write, Richard Henderson, 2021/11/10

Prev by Date: Re: [PATCH v2 12/14] target/riscv: Split out the vill from vtype
Next by Date: Re: [PATCH v2 14/14] target/riscv: Enable uxl field write
Previous by thread: [PATCH v2 13/14] target/riscv: Don't save pc when exception return
Next by thread: [PATCH v2 14/14] target/riscv: Enable uxl field write
Index(es):
- Date
- Thread