Re: [PATCH 2/7] block: Manipulate children list in .attach/.detach

[Vladimir Sementsov-Ogievskiy]

04.11.2021 13:38, Hanna Reitz wrote:
> The children list is specific to BDS parents.  We should not modify it
> in the general children modification code, but let BDS parents deal with
> it in their .attach() and .detach() methods.
>
> This also has the advantage that a BdrvChild is removed from the
> children list before its .bs pointer can become NULL.  BDS parents
> generally assume that their children's .bs pointer is never NULL, so
> this is actually a bug fix.
>
> Signed-off-by: Hanna Reitz<hreitz@redhat.com>


Interesting that nor child_root neither child_job do similar things in .attach 
/ .detach ... Should we do something with it?

--
Best regards,
Vladimir