Re: [PULL 03/54] target/ppc: Move load and store floating point instructions to decodetree

[Laurent Vivier]

On 09/11/2021 06:51, David Gibson wrote:
> From: Fernando Eckhardt Valle <phervalle@gmail.com>
>
> Move load floating point instructions (lfs, lfsu, lfsx, lfsux, lfd, lfdu, lfdx, 
> lfdux)
> and store floating point instructions(stfs, stfsu, stfsx, stfsux, stfd, stfdu, 
> stfdx,
> stfdux) from legacy system to decodetree.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Fernando Eckhardt Valle <fernando.valle@eldorado.org.br>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> Message-Id: <20211029202424.175401-4-matheus.ferst@eldorado.org.br>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>   target/ppc/insn32.decode           |  24 +++
>   target/ppc/translate/fp-impl.c.inc | 247 +++++++++--------------------
>   target/ppc/translate/fp-ops.c.inc  |  29 ----
>   3 files changed, 95 insertions(+), 205 deletions(-)

This patch breaks qemu linux-user with an ubuntu bionic chroot.

The fix proposed by Matheus [1] fixes it for me.
When will it be merged?
It's needed in 6.2

Thanks,
Laurent

[1] 
c799859a-4fdc-9d69-7a87-5e69cee15ef3@eldorado.org.br">https://patchew.org/QEMU/20211029202424.175401-1-matheus.ferst@eldorado.org.br/20211029202424.175401-4-matheus.ferst@eldorado.org.br/#c799859a-4fdc-9d69-7a87-5e69cee15ef3@eldorado.org.br

diff --git a/target/ppc/translate/fp-impl.c.inc 
b/target/ppc/translate/fp-impl.c.inc
index d1dbb1b96b..c9e05201d9 100644
--- a/target/ppc/translate/fp-impl.c.inc
+++ b/target/ppc/translate/fp-impl.c.inc
@@ -1328,7 +1328,7 @@ static bool do_lsfpsd(DisasContext *ctx, int rt, int ra, 
TCGv displ,
         set_fpr(rt, t0);
     }
     if (update) {
-        tcg_gen_mov_tl(cpu_gpr[rt], ea);
+        tcg_gen_mov_tl(cpu_gpr[ra], ea);
     }
     tcg_temp_free_i64(t0);
     tcg_temp_free(ea);