Re: [PATCH v3 3/5] numa: Support SGX numa in the monitor and Libvirt interfaces

[Philippe Mathieu-Daudé]

On 11/11/21 07:18, Yang Zhong wrote:
> On Wed, Nov 10, 2021 at 10:55:40AM -0600, Eric Blake wrote:
>> On Mon, Nov 01, 2021 at 12:20:07PM -0400, Yang Zhong wrote:
>>> Add the SGXEPCSection list into SGXInfo to show the multiple
>>> SGX EPC sections detailed info, not the total size like before.
>>> This patch can enable numa support for 'info sgx' command and
>>> QMP interfaces. The new interfaces show each EPC section info
>>> in one numa node. Libvirt can use QMP interface to get the
>>> detailed host SGX EPC capabilities to decide how to allocate
>>> host EPC sections to guest.
>>>
>>> (qemu) info sgx
>>>  SGX support: enabled
>>>  SGX1 support: enabled
>>>  SGX2 support: enabled
>>>  FLC support: enabled
>>>  NUMA node #0: size=67108864
>>>  NUMA node #1: size=29360128
>>>
>>> The QMP interface show:
>>> (QEMU) query-sgx
>>> {"return": {"sgx": true, "sgx2": true, "sgx1": true, "sections": \
>>> [{"node": 0, "size": 67108864}, {"node": 1, "size": 29360128}], "flc": 
>>> true}}
>>>
>>> (QEMU) query-sgx-capabilities
>>> {"return": {"sgx": true, "sgx2": true, "sgx1": true, "sections": \
>>> [{"node": 0, "size": 17070817280}, {"node": 1, "size": 17079205888}], 
>>> "flc": true}}
>>
>> Other than the different "size" values, how do these commands differ?
> 
> 
>   As for QMP interfaces,
>   The 'query-sgx' to get VM sgx detailed info, and 'query-sgx-capabilities' 
> to get
>   the host sgx capabilities and Libvirt can use this info to decide how to 
> allocate
>   virtual EPC sections to VMs.

What about renaming/aliasing as 'query-host-sgx' / 'query-guest-sgx'?