qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 12/25] assertions for blockob.h global state API


From: Hanna Reitz
Subject: Re: [PATCH v4 12/25] assertions for blockob.h global state API
Date: Fri, 12 Nov 2021 16:26:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

Subject: s/blockob.h/blockjob.h/

On 25.10.21 12:17, Emanuele Giuseppe Esposito wrote:
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
---
  blockjob.c | 10 ++++++++++
  1 file changed, 10 insertions(+)

diff --git a/blockjob.c b/blockjob.c
index fbd6c7d873..4982f6a2b5 100644
--- a/blockjob.c
+++ b/blockjob.c
@@ -61,6 +61,7 @@ static bool is_block_job(Job *job)
BlockJob *block_job_next(BlockJob *bjob)
  {
+    assert(qemu_in_main_thread());
      Job *job = bjob ? &bjob->job : NULL;

Here and...

      do {
@@ -72,6 +73,7 @@ BlockJob *block_job_next(BlockJob *bjob)
BlockJob *block_job_get(const char *id)
  {
+    assert(qemu_in_main_thread());
      Job *job = job_get(id);

...here, the assertion and declaration should be switched.

Hanna




reply via email to

[Prev in Thread] Current Thread [Next in Thread]