[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] job.c: add missing notifier initialization

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [PATCH v1] job.c: add missing notifier initialization
Date: Fri, 12 Nov 2021 21:04:14 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0

03.11.2021 19:21, Emanuele Giuseppe Esposito wrote:
It seems that on_idle list is not properly initialized like
the other notifiers.

Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
  job.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/job.c b/job.c
index dbfa67bb0a..54db80df66 100644
--- a/job.c
+++ b/job.c
@@ -352,6 +352,7 @@ void *job_create(const char *job_id, const JobDriver 
*driver, JobTxn *txn,
+    notifier_list_init(&job->on_idle);
job_state_transition(job, JOB_STATUS_CREATED);
      aio_timer_init(qemu_get_aio_context(), &job->sleep_timer,

Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

I don't think it worth applying it now:

job object is alloced with g_malloc0, so job->on_idle is initialized to zero.

notifier_list_init() simply calls QLIST_INIT(), which initializes the only 
field of QLIST structure to NULL. So, actually these notifier_list_init() calls 
are no-op in this context.

I queue it in jobs branch, but will not send a pull request until more critical 
fix comes for 6.2 or 6.3 development starts.


Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]