Re: [RFC PATCH v2 10/30] target/loongarch: Add other core instructions support

[Richard Henderson]

On 11/11/21 2:35 AM, Xiaojuan Yang wrote:
> +        if (qemu_loglevel_mask(CPU_LOG_INT)) {
> +            qemu_log("%s: TLBRERA 0x%lx\n", __func__, env->CSR_TLBRERA);
> +        }

This is qemu_log_mask, two instances.  With that,

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +void helper_ldpte(CPULoongArchState *env, target_ulong base, target_ulong odd,
> +                  uint32_t mem_idx)

It it is a bit disappointing that the manual does not describe this function in detail, 
only a high-level description.


r~