[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/13] softmmu/qdev-monitor: fix use-after-free in qdev_set_id()
From: |
Kevin Wolf |
Subject: |
[PULL 13/13] softmmu/qdev-monitor: fix use-after-free in qdev_set_id() |
Date: |
Mon, 15 Nov 2021 15:54:09 +0100 |
From: Stefan Hajnoczi <stefanha@redhat.com>
Reported by Coverity (CID 1465222).
Fixes: 4a1d937796de0fecd8b22d7dbebf87f38e8282fd ("softmmu/qdev-monitor: add
error handling in qdev_set_id")
Cc: Damien Hedde <damien.hedde@greensocs.com>
Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-Id: <20211102163342.31162-1-stefanha@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
softmmu/qdev-monitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/softmmu/qdev-monitor.c b/softmmu/qdev-monitor.c
index b5aaae4b8c..01ec420e61 100644
--- a/softmmu/qdev-monitor.c
+++ b/softmmu/qdev-monitor.c
@@ -593,8 +593,8 @@ const char *qdev_set_id(DeviceState *dev, char *id, Error
**errp)
if (prop) {
dev->id = id;
} else {
- g_free(id);
error_setg(errp, "Duplicate device ID '%s'", id);
+ g_free(id);
return NULL;
}
} else {
--
2.31.1
- [PULL 04/13] block: Drop detached child from ignore list, (continued)
- [PULL 04/13] block: Drop detached child from ignore list, Kevin Wolf, 2021/11/15
- [PULL 02/13] block: Manipulate children list in .attach/.detach, Kevin Wolf, 2021/11/15
- [PULL 03/13] block: Unite remove_empty_child and child_free, Kevin Wolf, 2021/11/15
- [PULL 05/13] block: Pass BdrvChild ** to replace_child_noperm, Kevin Wolf, 2021/11/15
- [PULL 06/13] block: Restructure remove_file_or_backing_child(), Kevin Wolf, 2021/11/15
- [PULL 08/13] block: Let replace_child_tran keep indirect pointer, Kevin Wolf, 2021/11/15
- [PULL 11/13] docs: Deprecate incorrectly typed device_add arguments, Kevin Wolf, 2021/11/15
- [PULL 12/13] file-posix: Fix alignment after reopen changing O_DIRECT, Kevin Wolf, 2021/11/15
- [PULL 10/13] iotests/030: Unthrottle parallel jobs in reverse, Kevin Wolf, 2021/11/15
- [PULL 09/13] block: Let replace_child_noperm free children, Kevin Wolf, 2021/11/15
- [PULL 13/13] softmmu/qdev-monitor: fix use-after-free in qdev_set_id(),
Kevin Wolf <=
- [PULL 07/13] transactions: Invoke clean() after everything else, Kevin Wolf, 2021/11/15
- Re: [PULL 00/13] Block layer patches, Richard Henderson, 2021/11/15
- Re: [PULL 00/13] Block layer patches, Philippe Mathieu-Daudé, 2021/11/15