qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 21/26] configure, meson: move more compiler checks to Meson


From: Paolo Bonzini
Subject: Re: [PULL 21/26] configure, meson: move more compiler checks to Meson
Date: Tue, 16 Nov 2021 10:29:28 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 11/15/21 17:42, Peter Maydell wrote:
Hi -- I've just noticed that this change breaks compilation for me,
because this test incorrectly fails to set CONFIG_IOVEC on a system
where the header defines 'struct iovec'. This seems to be because
"struct iovec" isn't a valid thing to test with has_header_symbol,
because it provokes a compiler error from clang.
https://github.com/mesonbuild/meson/issues/1975  says that for gcc
it's actually going to be wrong the other way (always setting CONFIG_IOVEC
whether the system header has the struct or not), because "struct wombat;"
is syntactically OK as a*declaration*, not a use.

Maybe we can work around this by testing for the presence of something else,
eg IOV_MAX or the readv or writev functions ?

It can just use cc.has_type.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]