[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: fix botched compile check conversions

From: Daniel P . Berrangé
Subject: Re: [PATCH] meson: fix botched compile check conversions
Date: Tue, 16 Nov 2021 13:15:12 +0000
User-agent: Mutt/2.0.7 (2021-05-04)

On Tue, Nov 16, 2021 at 01:10:04PM +0000, Peter Maydell wrote:
> On Tue, 16 Nov 2021 at 12:00, Daniel P. Berrangé <berrange@redhat.com> wrote:
> > I wonder if the problem is more fundamental than that. Passing
> > stuff in --extra-cflags is done to influence the flags used to
> > compile the QEMU end user binaries. Unfortunately --extra-cflags
> > is also getting applied to all the meson.build feature checks.
> >
> > IMHO we would get a more reliable result if the meson.build
> > checks were fully isolated from the cflags we used for building
> > everything else, so the checks get a well understood, predictable
> > environment.
> If you're using --extra-cflags to pass in "-I/path/to/libfoo/headers"
> then you do want that to be used in the meson check for "do we have
> libfoo", though...

For pkg-config-ized things meson lets you override those paths
per-library IIRC.

For the non-pkg-config-izied case, that could be an argument for
specialized --extra-header-dir=PATH and --extra-lib-dir=$PATH args.

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]