[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/3] docs: rSTify the "SubmitAPatch" wiki
From: |
Kashyap Chamarthy |
Subject: |
Re: [PATCH v3 3/3] docs: rSTify the "SubmitAPatch" wiki |
Date: |
Wed, 17 Nov 2021 16:35:15 +0100 |
On Wed, Nov 17, 2021 at 03:43:56PM +0100, Thomas Huth wrote:
> On 17/11/2021 11.25, Kashyap Chamarthy wrote:
[...]
> > > That ".". looks a little bit weird in the output ... maybe we should
> > > replace
> > > it with "does not end with a dot." ?
> >
> > Re-looking the output, yes it does look odd. And yes, your amendment
> > is good.
>
> I haven't updated that one while picking up the patch - so we might want to
> fix it with an additional patch on top.
Sure, no prob.
[...]
> > Thanks for the careful review and submitting the PR. I'm assuming I
> > don't need to respin a v4.
>
> Right, patches have been merged now.
Thanks!
> Something I just noticed afterwards, after looking at the pages online:
> https://www.qemu.org/docs/master/devel/submitting-a-pull-request.html uses
> "Submit" in the heading, while
> https://www.qemu.org/docs/master/devel/submitting-a-patch.html uses
> "Submitting" ... looks a little bit inconsequent ... should we change it to
> use one form only? The Wiki used "submit", not "submitting", so maybe use
> that one?
Right, I generally also prefer the imperative mood ("submit"). I went
with "submitting" to keep things a bit consistent with the existing
convention: 'writing-qmp-commands.rst", "testing.rst", "tracing.rst",
"secure-coding-practises.rst", etc. And as discussed on #qemu, OFTC,
I'll update the heading in submitting-a-pull-request.rst from "submit"
to "submitting".
Also, thanks for reminding on IRC of updating 'qemu-web' links to update
from Wiki to the in-tree docs.
https://www.qemu.org/contribute/
I'll send a follow-up for that. I see a three occurrences in the
'qemu-web' repo:
$> git grep SubmitAPatch
CONTRIBUTING.md:https://wiki.qemu.org/Contribute/SubmitAPatch
contribute.md:Please do not submit merge requests on GitLab; patches are
sent to the mailing list according to QEMU's [patch submissions
guidelines](https://wiki.qemu.org/Contribute/SubmitAPatch).
contribute/report-a-bug.md:QEMU does not use GitLab merge requests; patches
are sent to the mailing list according to QEMU's [patch submissions
guidelines](https://wiki.qemu.org/Contribute/SubmitAPatch).
--
/kashyap
Re: [PATCH v3 0/3] rSTify contribution-related wiki pages, Philippe Mathieu-Daudé, 2021/11/10