[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH] plugins/meson.build: fix linker issue with weird paths (

From: Stefan Weil
Subject: Re: [RFC PATCH] plugins/meson.build: fix linker issue with weird paths (for v6.2?)
Date: Wed, 17 Nov 2021 20:39:14 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

Am 17.11.21 um 12:19 schrieb Alex Bennée:
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: https://gitlab.com/qemu-project/qemu/-/issues/712
  plugins/meson.build | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

Thank you. The fix works for me and looks fine. meson.project_build_root() was only used there, so hopefully no other code was affected.

I tested builds on Debian GNU Linux x86_64 bullseye and latest MacOS and would appreciate if the fix could be applied for release 6.2.

Tested-by: Stefan Weil <sw@weilnetz.de>

diff --git a/plugins/meson.build b/plugins/meson.build
index aeb386ebae..b3de57853b 100644
--- a/plugins/meson.build
+++ b/plugins/meson.build
@@ -2,9 +2,9 @@ plugin_ldflags = []
  # Modules need more symbols than just those in plugins/qemu-plugins.symbols
  if not enable_modules
    if 'CONFIG_HAS_LD_DYNAMIC_LIST' in config_host
-    plugin_ldflags = ['-Wl,--dynamic-list=' + (meson.project_build_root() / 
+    plugin_ldflags = ['-Wl,--dynamic-list=qemu-plugins-ld.symbols']
    elif 'CONFIG_HAS_LD_EXPORTED_SYMBOLS_LIST' in config_host
-    plugin_ldflags = ['-Wl,-exported_symbols_list,' + 
(meson.project_build_root() / 'qemu-plugins-ld64.symbols')]
+    plugin_ldflags = ['-Wl,-exported_symbols_list,qemu-plugins-ld64.symbols']

reply via email to

[Prev in Thread] Current Thread [Next in Thread]