[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 13/13] blockdev: Drop unused drive_get_next()

From: Hanna Reitz
Subject: Re: [PATCH v2 13/13] blockdev: Drop unused drive_get_next()
Date: Thu, 18 Nov 2021 09:07:32 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 17.11.21 17:34, Markus Armbruster wrote:
drive_get_next() is basically a bad idea.  It returns the "next" block
backend of a certain interface type.  "Next" means bus=0,unit=N, where
subsequent calls count N up from zero, per interface type.

This lets you define unit numbers implicitly by execution order.  If the
order changes, or new calls appear "in the middle", unit numbers change.
ABI break.  Hard to spot in review.

The previous commits eliminated all uses.  Drop the function.

Cc: Kevin Wolf <kwolf@redhat.com>
Cc: Hanna Reitz <hreitz@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
  include/sysemu/blockdev.h |  1 -
  blockdev.c                | 10 ----------
  2 files changed, 11 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]