[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH-for-6.2? v2 2/5] docs/devel/style: Improve Error** functions rST
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH-for-6.2? v2 2/5] docs/devel/style: Improve Error** functions rST rendering |
Date: |
Thu, 18 Nov 2021 15:57:13 +0100 |
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
docs/devel/style.rst | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/docs/devel/style.rst b/docs/devel/style.rst
index 3e519dc6ade..1a23021bc3e 100644
--- a/docs/devel/style.rst
+++ b/docs/devel/style.rst
@@ -602,16 +602,16 @@ Error handling and reporting
Reporting errors to the human user
----------------------------------
-Do not use printf(), fprintf() or monitor_printf(). Instead, use
-error_report() or error_vreport() from error-report.h. This ensures the
-error is reported in the right place (current monitor or stderr), and in
-a uniform format.
+Do not use ``printf()``, ``fprintf()`` or ``monitor_printf()``. Instead, use
+``error_report()`` or ``error_vreport()`` from error-report.h. This ensures
+the error is reported in the right place (current monitor or ``stderr``), and
+in a uniform format.
-Use error_printf() & friends to print additional information.
+Use ``error_printf()`` & friends to print additional information.
-error_report() prints the current location. In certain common cases
+``error_report()`` prints the current location. In certain common cases
like command line parsing, the current location is tracked
-automatically. To manipulate it manually, use the loc_``*``() from
+automatically. To manipulate it manually, use the ``loc_*()`` from
error-report.h.
Propagating errors
@@ -621,7 +621,7 @@ An error can't always be reported to the user right where
it's detected,
but often needs to be propagated up the call chain to a place that can
handle it. This can be done in various ways.
-The most flexible one is Error objects. See error.h for usage
+The most flexible one is ``Error`` objects. See error.h for usage
information.
Use the simplest suitable method to communicate success / failure to
@@ -631,10 +631,10 @@ error, non-negative / -errno, non-null / null, or Error
objects.
Example: when a function returns a non-null pointer on success, and it
can fail only in one way (as far as the caller is concerned), returning
null on failure is just fine, and certainly simpler and a lot easier on
-the eyes than propagating an Error object through an Error ``*````*``
parameter.
+the eyes than propagating an Error object through an ``Error **`` parameter.
Example: when a function's callers need to report details on failure
-only the function really knows, use Error ``*````*``, and set suitable errors.
+only the function really knows, use ``Error **``, and set suitable errors.
Do not report an error to the user when you're also returning an error
for somebody else to handle. Leave the reporting to the place that
@@ -643,17 +643,17 @@ consumes the error returned.
Handling errors
---------------
-Calling exit() is fine when handling configuration errors during
+Calling ``exit()`` is fine when handling configuration errors during
startup. It's problematic during normal operation. In particular,
-monitor commands should never exit().
+monitor commands should never ``exit()``.
-Do not call exit() or abort() to handle an error that can be triggered
+Do not call ``exit()`` or ``abort()`` to handle an error that can be triggered
by the guest (e.g., some unimplemented corner case in guest code
translation or device emulation). Guests should not be able to
terminate QEMU.
-Note that &error_fatal is just another way to exit(1), and &error_abort
-is just another way to abort().
+Note that ``&error_fatal`` is just another way to ``exit(1)``, and
+``&error_abort`` is just another way to ``abort()``.
trace-events style
--
2.31.1
- [PATCH-for-6.2? v2 0/5] docs/devel/style: Improve rST rendering, Philippe Mathieu-Daudé, 2021/11/18
- [PATCH-for-6.2? v2 1/5] docs/devel/style: Render C types as monospaced text, Philippe Mathieu-Daudé, 2021/11/18
- [PATCH-for-6.2? v2 2/5] docs/devel/style: Improve Error** functions rST rendering,
Philippe Mathieu-Daudé <=
- [PATCH-for-6.2? v2 3/5] docs/devel/style: Improve string format rST rendering, Philippe Mathieu-Daudé, 2021/11/18
- [PATCH-for-6.2? v2 4/5] docs/devel/style: Render C function names as monospaced text, Philippe Mathieu-Daudé, 2021/11/18
- [PATCH-for-6.2? v2 5/5] docs/devel/style: Misc rST rendering improvements, Philippe Mathieu-Daudé, 2021/11/18
- Re: [PATCH-for-6.2? v2 0/5] docs/devel/style: Improve rST rendering, Darren Kenny, 2021/11/18