[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/7] python/machine: add instance disambiguator to default ni

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/7] python/machine: add instance disambiguator to default nickname
Date: Fri, 19 Nov 2021 09:54:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 11/18/21 21:46, John Snow wrote:
> If you create two instances of QEMUMachine(), they'll both create the
> same nickname by default -- which is not that helpful.
> Luckily, they'll both create unique temporary directories ... but due to
> user configuration, they may share logging and sockfile directories,
> meaning two instances can collide. The Python logging will also be quite
> confusing, with no differentiation between the two instances.
> Add an instance disambiguator (The memory address of the instance) to
> the default nickname to foolproof this in all cases.
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/machine/machine.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]