Re: [PATCH-for-6.2 2/2] hw/display: Do not allow multiple identical VGA devices

[Philippe Mathieu-Daudé]

On 11/19/21 10:20, Paolo Bonzini wrote:
> On 11/18/21 20:20, Philippe Mathieu-Daudé wrote:
>> +    if (obj) {
>> +        const char *typename = object_get_typename(obj);
>> +
>> +        /*
>> +         * make sure this device is not being added twice,
>> +         * if so exit without crashing qemu
>> +         */
>> +        if (object_resolve_path_type("", typename, NULL)) {
>> +            error_setg(errp, "at most one %s device is permitted",
>> typename);
>> +            return false;
>> +        }
>> +    }
>> +
> 
> Wouldn't it give the same error with one ISA and one PCI VGA?

In that case I'd expect the object path to be different...

Anyhow, the fix from commit 7852a77f598 doesn't seem to work well:

$ qemu-system-x86_64 -M q35 -nodefaults -device isa-vga
qemu-system-x86_64: -device isa-vga: at most one isa-vga device is permitted