Re: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu

From:	Richard Henderson
Subject:	Re: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu
Date:	Sat, 20 Nov 2021 23:19:07 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 11/20/21 8:46 AM, Yifei Jiang wrote:

+    id = kvm_riscv_reg_id(env, KVM_REG_RISCV_CONFIG, 
KVM_REG_RISCV_CONFIG_REG(isa));
+    ret = kvm_get_one_reg(cs, id, &isa);
+    if (ret) {
+        return ret;
+    }
+    env->misa_mxl |= isa;


This doesn't look right.
I'm sure you meant

    env->misa_ext = isa;


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v1 00/12] Add riscv kvm accel support, Yifei Jiang, 2021/11/20
- [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu, Yifei Jiang, 2021/11/20
  - Re: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu, Richard Henderson <=
- [PATCH v1 05/12] target/riscv: Implement kvm_arch_put_registers, Yifei Jiang, 2021/11/20
- [PATCH v1 02/12] target/riscv: Add target/riscv/kvm.c to place the public kvm interface, Yifei Jiang, 2021/11/20
- [PATCH v1 01/12] update-linux-headers: Add asm-riscv/kvm.h, Yifei Jiang, 2021/11/20
  - Re: [PATCH v1 01/12] update-linux-headers: Add asm-riscv/kvm.h, Alistair Francis, 2021/11/23
- [PATCH v1 06/12] target/riscv: Support start kernel directly by KVM, Yifei Jiang, 2021/11/20
- [PATCH v1 04/12] target/riscv: Implement kvm_arch_get_registers, Yifei Jiang, 2021/11/20
- [PATCH v1 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit, Yifei Jiang, 2021/11/20
  - Re: [PATCH v1 08/12] target/riscv: Handle KVM_EXIT_RISCV_SBI exit, Philippe Mathieu-Daudé, 2021/11/20
- [PATCH v1 07/12] target/riscv: Support setting external interrupt by KVM, Yifei Jiang, 2021/11/20
- [PATCH v1 09/12] target/riscv: Add host cpu type, Yifei Jiang, 2021/11/20

Prev by Date: Re: [PATCH v1 0/9] hw/mos6522: VIA timer emulation fixes and improvements
Next by Date: Re: [PATCH v1 12/12] target/riscv: Support virtual time context synchronization
Previous by thread: [PATCH v1 03/12] target/riscv: Implement function kvm_arch_init_vcpu
Next by thread: [PATCH v1 05/12] target/riscv: Implement kvm_arch_put_registers
Index(es):
- Date
- Thread