[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v11 04/26] target/loongarch: Add fixed point arithmetic instr
From: |
gaosong |
Subject: |
Re: [PATCH v11 04/26] target/loongarch: Add fixed point arithmetic instruction translation |
Date: |
Mon, 22 Nov 2021 16:23:27 +0800 |
User-agent: |
Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
Hi Richard,
Sorry for the late reply.
On 2021/11/20 下午4:56, Richard Henderson
wrote:
On
11/20/21 9:52 AM, gaosong wrote:
You're right, gen_set_gpr not need
EXT_NONE at all, and we need not condition around gen_set_gpr.
I think that if we know the dst_ext is EXT_NONE, we do't need
gen_set_gpr.
But that assumes that gpr_dst did not return a temporary.
I think it's cleaner to assume that gen_set_gpr is needed.
Does this mean that we gen_set_gpr where used gpr_dst, and gen_set_gpr need EXT_NONE?
Such as gpr_dst in trans_atomic.c.inc/trans_memory.c.inc, should we need gen_set_gpr?
Thanks
Song Gao
r~
- Re: [PATCH v11 05/26] target/loongarch: Add fixed point shift instruction translation, (continued)
[PATCH v11 01/26] target/loongarch: Add README, Song Gao, 2021/11/19
[PATCH v11 06/26] target/loongarch: Add fixed point bit instruction translation, Song Gao, 2021/11/19
[PATCH v11 07/26] target/loongarch: Add fixed point load/store instruction translation, Song Gao, 2021/11/19
[PATCH v11 02/26] target/loongarch: Add core definition, Song Gao, 2021/11/19
[PATCH v11 03/26] target/loongarch: Add main translation routines, Song Gao, 2021/11/19
[PATCH v11 11/26] target/loongarch: Add floating point comparison instruction translation, Song Gao, 2021/11/19