[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.

From: Thomas Huth
Subject: Re: [PATCH 1/2] docs: Fix botched rST conversion of 'submitting-a-patch.rst'
Date: Mon, 22 Nov 2021 11:36:54 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 22/11/2021 11.20, Kashyap Chamarthy wrote:
On Mon, Nov 22, 2021 at 10:51:15AM +0100, Thomas Huth wrote:
On 19/11/2021 20.31, Kashyap Chamarthy wrote:
I completely botched up the merged[0] rST conversion of this document by
accidentally dropping entire hunks (!) of text. :-(  I made it very hard
for reviewers to spot it, as the omitted text was buried deep in the
document.  To fix my hatchet job, I reconverted the "SubmitAPatch"
wiki[1] page from scratch and replaced the existing rST with it, while
making sure I incorporated previous feedback.

Thanks for the quick update! I've now tripple-checked the differences
between the old wiki page and the new rst page, and I think with some
additional small changes on top (which I will do while picking up your
patch, see below), we should be fine now.

Thanks for your eagle eyes.


-- `QEMU Coding Style
-  <https://qemu-project.gitlab.io/qemu/devel/style.html>`__
+-  `QEMU Coding Style <https://qemu-project.gitlab.io/qemu/devel/style.html>`__

While we're at it, I'll replace the link with an internal link when picking
up this patch (so that it can also be used in offline documentation).


   -  `Automate a checkpatch run on
-   commit 
+   commit 
+-  Spell check your patches

I'll add the link to https://wiki.qemu.org/Contribute/SpellCheck again.

Please don't -- I intentionally dropped it in a previous iteration based
on this feedback from Peter Maydell:

     "I'm not sure that SpellCheck in particular is sufficiently baked
     to be in the actual docs. I'd rather just drop the reference to it
     from SubmitAPatch."

Ok, so I'll drop that line completely (otherwise it does not really make sense to have it in this list after the "See also:" right in front of it).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]