Re: [PATCH v2 03/10] include/hw/dma/xlnx_csu_dma: Include ptimer.h and stream.h in the header

[Philippe Mathieu-Daudé]

On 11/23/21 11:34, Francisco Iglesias wrote:
> Include ptimer.h and stream.h in the header for being able to build and
> reuse the DMA model (the first usage of StreamSink, StreamCanPushNotifyFn
> and ptimer_state is in the header).
> 
> Signed-off-by: Francisco Iglesias <francisco.iglesias@xilinx.com>
> ---
>  include/hw/dma/xlnx_csu_dma.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/hw/dma/xlnx_csu_dma.h b/include/hw/dma/xlnx_csu_dma.h
> index 9e9dc551e9..8c39e46f58 100644
> --- a/include/hw/dma/xlnx_csu_dma.h
> +++ b/include/hw/dma/xlnx_csu_dma.h
> @@ -21,6 +21,9 @@
>  #ifndef XLNX_CSU_DMA_H
>  #define XLNX_CSU_DMA_H
>  
> +#include "hw/ptimer.h"

Yes, but arguably ptimer_state should be forward
declared in "include/qemu/typedefs.h" IMO.

> +#include "hw/stream.h"

OK but you forgot these:

include/hw/sysbus.h (SysBusDevice)
include/exec/memory.h (MemoryRegion)
include/exec/memattrs.h (MemTxAttrs)
include/exec/memory.h (AddressSpace)
include/hw/register.h (RegisterInfo)