Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global <driver>.<property>=<val> option

[Paolo Bonzini]

On 11/22/21 15:32, Markus Armbruster wrote:
> >    qemu-system-x86_64: warning: global cfi.pflash01.secure has invalid class 
> > name
> >
> > what's going on here ?
> Off-the-cuff guess: cfi.pflash01.secure=on gets parsed as
>
>      driver=cfi
>      property=pflash01.secure
>      value=on
>
> Once again our "anything goes" attitude to naming wastes us time and
> thus money.

I'd blame more the sscanf parsing.  Anyway, -global 
driver=...,property=...,value=... works just fine in all cases, it's 
just more verbose---and it might even be easier to use for Libvirt, if 
it can use its usual QemuOpts-building facilities.

Anyhow, this patch breaks existing clients, as pointed out by Markus.

Paolo

> In contrast, QAPI restricts names to "only ASCII letters, digits,
> hyphen, and underscore" (see docs/devel/qapi-code-gen.rst section Naming
> rules and reserved names).