[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global <drive
Re: [RFC PATCH-for-6.2 v3] qdev-monitor: Only allow full --global <driver>.<property>=<val> option
Tue, 23 Nov 2021 14:17:54 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0
On 11/22/21 15:32, Markus Armbruster wrote:
qemu-system-x86_64: warning: global cfi.pflash01.secure has invalid class
what's going on here ?
Off-the-cuff guess: cfi.pflash01.secure=on gets parsed as
Once again our "anything goes" attitude to naming wastes us time and
I'd blame more the sscanf parsing. Anyway, -global
driver=...,property=...,value=... works just fine in all cases, it's
just more verbose---and it might even be easier to use for Libvirt, if
it can use its usual QemuOpts-building facilities.
Anyhow, this patch breaks existing clients, as pointed out by Markus.
In contrast, QAPI restricts names to "only ASCII letters, digits,
hyphen, and underscore" (see docs/devel/qapi-code-gen.rst section Naming
rules and reserved names).