[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH resend v2] qemu-binfmt-conf.sh: fix -F option

From: Laurent Vivier
Subject: Re: [PATCH resend v2] qemu-binfmt-conf.sh: fix -F option
Date: Mon, 29 Nov 2021 15:44:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

Le 29/11/2021 à 14:51, mwilck@suse.com a écrit :
From: Martin Wilck <mwilck@suse.com>

qemu-binfmt-conf.sh should use "-F" as short option for "--qemu-suffix".
Fix the getopt call to make this work.

Signed-off-by: Martin Wilck <mwilck@suse.com>
previous: https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg03132.html

Sorry for the delay, didn't see the email.

To put "linux-user" in the email subject helps to pass through all my email 

ref: https://bugzilla.opensuse.org/show_bug.cgi?id=1186256

I think you don't need the suffix anymore with the new "--preserve-argv0" 


    6e1c0d7b951e ("linux-user: manage binfmt-misc preserve-arg[0] flag")

but you need v5.12 kernel.

    2347961b11d4 ("binfmt_misc: pass binfmt_misc flags to the interpreter")

Moreover it seems it will be possible (soon?) to use a binfmt_misc 
configuration per container;

  [1/2] binfmt_misc: cleanup on filesystem umount

  [2/2/] binfmt_misc: enable sandboxed mounts


  scripts/qemu-binfmt-conf.sh | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/scripts/qemu-binfmt-conf.sh b/scripts/qemu-binfmt-conf.sh
index 7de996d536..e9bfeb94d3 100755
--- a/scripts/qemu-binfmt-conf.sh
+++ b/scripts/qemu-binfmt-conf.sh
@@ -340,7 +340,9 @@ PERSISTENT=no
-options=$(getopt -o ds:Q:S:e:hc:p:g: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,preserve-argv0: -- "$@")
+options=$(getopt -o ds:Q:S:e:hc:p:g:F: -l ${_longopts} -- "$@")
  eval set -- "$options"
while true ; do

Fixes: 7155be7cda5c ("qemu-binfmt-conf.sh: allow to provide a suffix to the 
interpreter name")

Reviewed-by: Laurent Vivier <laurent@vivier.eu>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]