[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 8/8] tests/plugin/syscall.c: fix compiler warnings
From: |
Alex Bennée |
Subject: |
[PULL 8/8] tests/plugin/syscall.c: fix compiler warnings |
Date: |
Mon, 29 Nov 2021 17:14:49 +0000 |
From: Juro Bystricky <juro.bystricky@intel.com>
Fix compiler warnings. The warnings can result in a broken build.
This patch fixes warnings such as:
In file included from /usr/include/glib-2.0/glib.h:111,
from ../tests/plugin/syscall.c:13:
../tests/plugin/syscall.c: In function ‘print_entry’:
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: ‘out’ may be
used uninitialized in this function [-Werror=maybe-uninitialized]
g_free (*pp);
^~~~~~~~~~~~
../tests/plugin/syscall.c:82:23: note: ‘out’ was declared here
g_autofree gchar *out;
^~~
In file included from /usr/include/glib-2.0/glib.h:111,
from ../tests/plugin/syscall.c:13:
../tests/plugin/syscall.c: In function ‘vcpu_syscall_ret’:
/usr/include/glib-2.0/glib/glib-autocleanups.h:28:3: error: ‘out’ may be
used uninitialized in this function [-Werror=maybe-uninitialized]
g_free (*pp);
^~~~~~~~~~~~
../tests/plugin/syscall.c:73:27: note: ‘out’ was declared here
g_autofree gchar *out;
^~~
cc1: all warnings being treated as errors
Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20211128011551.2115468-1-juro.bystricky@intel.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20211129140932.4115115-9-alex.bennee@linaro.org>
diff --git a/tests/plugin/syscall.c b/tests/plugin/syscall.c
index 484b48de49..96040c578f 100644
--- a/tests/plugin/syscall.c
+++ b/tests/plugin/syscall.c
@@ -70,19 +70,17 @@ static void vcpu_syscall_ret(qemu_plugin_id_t id, unsigned
int vcpu_idx,
}
g_mutex_unlock(&lock);
} else {
- g_autofree gchar *out;
- out = g_strdup_printf("syscall #%" PRIi64 " returned -> %" PRIi64 "\n",
- num, ret);
+ g_autofree gchar *out = g_strdup_printf(
+ "syscall #%" PRIi64 " returned -> %" PRIi64 "\n", num, ret);
qemu_plugin_outs(out);
}
}
static void print_entry(gpointer val, gpointer user_data)
{
- g_autofree gchar *out;
SyscallStats *entry = (SyscallStats *) val;
int64_t syscall_num = entry->num;
- out = g_strdup_printf(
+ g_autofree gchar *out = g_strdup_printf(
"%-13" PRIi64 "%-6" PRIi64 " %" PRIi64 "\n",
syscall_num, entry->calls, entry->errors);
qemu_plugin_outs(out);
--
2.30.2
- [PULL for 6.2 0/8] more tcg, plugin, test and build fixes, Alex Bennée, 2021/11/29
- [PULL 1/8] accel/tcg: introduce CF_NOIRQ, Alex Bennée, 2021/11/29
- [PULL 2/8] accel/tcg: suppress IRQ check for special TBs, Alex Bennée, 2021/11/29
- [PULL 4/8] plugins/meson.build: fix linker issue with weird paths, Alex Bennée, 2021/11/29
- [PULL 5/8] gdbstub: handle a potentially racing TaskState, Alex Bennée, 2021/11/29
- [PULL 3/8] tests/avocado: fix tcg_plugin mem access count test, Alex Bennée, 2021/11/29
- [PULL 6/8] MAINTAINERS: Remove me as a reviewer for the build and test/avocado, Alex Bennée, 2021/11/29
- [PULL 7/8] MAINTAINERS: Add section for Aarch64 GitLab custom runner, Alex Bennée, 2021/11/29
- [PULL 8/8] tests/plugin/syscall.c: fix compiler warnings,
Alex Bennée <=
- Re: [PULL for 6.2 0/8] more tcg, plugin, test and build fixes, Richard Henderson, 2021/11/29