Re: SME : Please review and merge : hw/arm/aspeed: Added eMMC boot support for AST2600 image.

[Peter Maydell]

On Tue, 9 Nov 2021 at 18:04, Shitalkumar Gandhi <shital_909@yahoo.com> wrote:
>
> Hi SME's,
>
> Please see the attached patch, which has been added to the boot eMMC image 
> for AST2600 machine on QEMU.
>
> qemu should be run as follows:
>
> ./qemu-system-arm -m 1G -M ast2600-evb -nographic -drive
> file=mmc-evb-ast2600.img,format=raw,if=sd,index=2
>
> Tested: Booted AST2600 eMMC image on QEMU.
>
> Suggested-by: Troy Lee leetroy@gmail.com
> Reviewed-by: Troy Lee leetroy@gmail.com
> Reviewed-by: Andrew Jeffery andrew@aj.id.au
> Signed-off-by: Shitalkumar Gandhi shitalkumar.gandhi@seagate.com

Hi; thanks for this patch.

Fishing the patch out of the attachment, the diff is:

diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index ba5f1dc5af..6a890adb83 100644
--- a/hw/arm/aspeed.c
+++ b/hw/arm/aspeed.c
@@ -148,7 +148,7 @@ struct AspeedMachineState {
         SCU_AST2400_HW_STRAP_BOOT_MODE(AST2400_SPI_BOOT))

 /* AST2600 evb hardware value */
-#define AST2600_EVB_HW_STRAP1 0x000000C0
+#define AST2600_EVB_HW_STRAP1 (0x000000C0 | AST26500_HW_STRAP_BOOT_SRC_EMMC)
 #define AST2600_EVB_HW_STRAP2 0x00000003

 /* Tacoma hardware value */
-- 

I've CC'd the aspeed maintainers, but since this has Andrew's R-by tag already
I'll put this into my set of patches to apply via target-arm.next for 7.0
unless somebody objects.

thanks
-- PMM