[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup

From: Richard Henderson
Subject: Re: [PATCH for-7.0 0/4] qemu-common.h include cleanup
Date: Tue, 30 Nov 2021 09:40:49 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 11/29/21 9:05 PM, Peter Maydell wrote:
qemu-common.h has a comment at the top:

  * This file is supposed to be included only by .c files. No header file should
  * depend on qemu-common.h, as this would easily lead to circular header
  * dependencies.

We still have a few .h files which include it, though.  The first 3
patches in this series fix that: in 3 out of 4 cases we didn't need
the #include at all, and in the 4th case we can instead #include
qemu-common.h from just one .c file.

Patch 4 is just removing the #include from 8 files in hw/arm which
don't need it at all.  (Probably there are other files like this, but
I just did the Arm related ones.)

Tested by pushing to gitlab for the CI build.

-- PMM

Peter Maydell (4):
   include/hw/i386: Don't include qemu-common.h in .h files
   target/hexagon/cpu.h: don't include qemu-common.h
   target/rx/cpu.h: Don't include qemu-common.h
   hw/arm: Don't include qemu-common.h unnecessarily

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]