[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation
From: |
Brian Cain |
Subject: |
RE: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation |
Date: |
Tue, 7 Dec 2021 15:26:24 +0000 |
> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
...
> On Tue, 7 Dec 2021 at 15:18, Brian Cain <bcain@quicinc.com> wrote:
> > Peter Maydell wrote:
> > > I won't try to put this into 6.2 unless you have a common guest
> > > that runs into this bug.
>
> > I know that Qualcomm encounters this issue with its hypervisor
> (https://github.com/quic/gunyah-hypervisor). Apologies for not being familiar
> -- "common guest" means multiple guest systems/OSs that encounter the
> issue? Does that mean that it would not suffice to demonstrate the issue for
> the one known case?
>
> It means "if you see this with a Linux, BSD etc guest that's
> more important than if you see this with some oddball thing
> nobody else is using and whose users aren't as likely to be
> using release versions of QEMU rather than mainline".
Ok, gotcha, thanks for the clarification :)
> The bug is a bug in any case and we'll fix it, it's just a
> question of whether it meets the bar to go into 6.2, which is
> hopefully going to have its final RC tagged today. If this
> patch had arrived a week ago then the bar would have been
> lower and it would definitely have gone in. As it is I have
> to weigh up the chances of this change causing a regression
> for eg KVM running on emulated QEMU.
I understand, and it sounds like the right call.
Thanks!
-Brian
Re: [PATCH v2 for 6.2?] gicv3: fix ICH_MISR's LRENP computation, Damien Hedde, 2021/12/07