[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/6] target/arm: Honor TCR_ELx.{I}PS
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 3/6] target/arm: Honor TCR_ELx.{I}PS |
Date: |
Thu, 9 Dec 2021 08:43:28 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
Hi Richard,
On 12/9/21 00:11, Richard Henderson wrote:
> This field controls the output (intermediate) physical address size
> of the translation process. V8 requires to raise an AddressSize
> fault if the page tables are programmed incorrectly, such that any
> intermediate descriptor address, or the final translated address,
> is out of range.
>
I'd split this patch as:
> Add an outputsize field to ARMVAParameters,
^ 1
> and fill it in during
> aa64_va_parameters.
^2
> Pass the value to check_s2_mmu_setup to use
> instead of the raw PAMax value.
^1
> Test the descaddr as extracted
> from TTBR and from page table entries.
^2
> Restrict descaddrmask so that we won't raise the fault for v7.
^ could be in 1 (simpler) or 2 if you think it makes sense.
This way #1 is a preliminary refactor/cleanup,
and #2 is only the ps field and V8 addition.
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/internals.h | 1 +
> target/arm/helper.c | 92 +++++++++++++++++++++++++++++-------------
> 2 files changed, 65 insertions(+), 28 deletions(-)
- [PATCH for-7.0 0/6] target/arm: Implement LVA, LPA, LPA2 features, Richard Henderson, 2021/12/08
- [PATCH 2/6] target/arm: Move arm_pamax out of line, Richard Henderson, 2021/12/08
- [PATCH 1/6] target/arm: Fault on invalid TCR_ELx.TxSZ, Richard Henderson, 2021/12/08
- [PATCH 4/6] target/arm: Implement FEAT_LVA, Richard Henderson, 2021/12/08
- [PATCH 3/6] target/arm: Honor TCR_ELx.{I}PS, Richard Henderson, 2021/12/08
- [PATCH 5/6] target/arm: Implement FEAT_LPA, Richard Henderson, 2021/12/08
- [PATCH 6/6] target/arm: Implement FEAT_LPA2, Richard Henderson, 2021/12/08
- Re: [PATCH for-7.0 0/6] target/arm: Implement LVA, LPA, LPA2 features, Alex Bennée, 2021/12/14