|
From: | Alex Bennée |
Subject: | Re: [PATCH 18/26] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value |
Date: | Mon, 13 Dec 2021 13:41:17 +0000 |
User-agent: | mu4e 1.7.5; emacs 28.0.90 |
Peter Maydell <peter.maydell@linaro.org> writes: > process_its_cmd() returns a bool, like all the other process_ functions. > However we were putting its return value into 'res', not 'result', > which meant we would ignore it when deciding whether to continue > or stall the command queue. Fix the typo. Arguably having to generic result types is confusing. Naming things is hard but maybe it should be a clear: MemTxResult memtx_res = MEMTX_OK; ItsCmdResult its_res = CMD_CONTINUE; ? Anyway: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |