[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] linux-user: Remove the deprecated ppc64abi32 target
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] linux-user: Remove the deprecated ppc64abi32 target |
Date: |
Wed, 15 Dec 2021 12:17:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 |
On 12/15/21 09:49, Thomas Huth wrote:
> It's likely broken, and nobody cared for picking it up again
> during the deprecation phase, so let's remove this now.
>
> Since this is the last entry in deprecated_targets_list, remove
> the related code in the configure script, too.
Can we keep that part to keep the gate open to deprecate more
targets / features?
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .gitlab-ci.d/buildtest.yml | 27 -----------------
> configs/targets/ppc64abi32-linux-user.mak | 8 -----
> configure | 29 +------------------
> docs/about/deprecated.rst | 7 -----
> docs/about/removed-features.rst | 8 +++++
> docs/user/main.rst | 1 -
> linux-user/elfload.c | 4 +--
> linux-user/ppc/signal.c | 11 ++-----
> linux-user/ppc/target_syscall.h | 4 +--
> linux-user/syscall_defs.h | 6 ++--
> .../dockerfiles/debian-ppc64el-cross.docker | 2 +-
> tests/tcg/configure.sh | 2 +-
> 12 files changed, 21 insertions(+), 88 deletions(-)
> delete mode 100644 configs/targets/ppc64abi32-linux-user.mak
> diff --git a/configure b/configure
> index 48c21775f3..da34ab0e12 100755
> --- a/configure
> +++ b/configure
> @@ -1295,8 +1295,6 @@ if [ "$ARCH" = "unknown" ]; then
> fi
>
> default_target_list=""
> -deprecated_targets_list=ppc64abi32-linux-user
> -deprecated_features=""
> mak_wilds=""
>
> if [ "$softmmu" = "yes" ]; then
> @@ -1309,16 +1307,6 @@ if [ "$bsd_user" = "yes" ]; then
> mak_wilds="${mak_wilds} $source_path/configs/targets/*-bsd-user.mak"
> fi
>
> -# If the user doesn't explicitly specify a deprecated target we will
> -# skip it.
> -if test -z "$target_list"; then
> - if test -z "$target_list_exclude"; then
> - target_list_exclude="$deprecated_targets_list"
> - else
> - target_list_exclude="$target_list_exclude,$deprecated_targets_list"
> - fi
> -fi
> -
> for config in $mak_wilds; do
> target="$(basename "$config" .mak)"
> if echo "$target_list_exclude" | grep -vq "$target"; then
> @@ -1337,11 +1325,9 @@ Standard options:
> --prefix=PREFIX install in PREFIX [$prefix]
> --interp-prefix=PREFIX where to find shared libraries, etc.
> use %M for cpu name [$interp_prefix]
> - --target-list=LIST set target list (default: build all
> non-deprecated)
> + --target-list=LIST set target list (default: build all)
> $(echo Available targets: $default_target_list | \
> fold -s -w 53 | sed -e 's/^/ /')
> -$(echo Deprecated targets: $deprecated_targets_list | \
> - fold -s -w 53 | sed -e 's/^/ /')
> --target-list-exclude=LIST exclude a set of targets from the default
> target-list
>
> Advanced options (experts only):
> @@ -1827,13 +1813,6 @@ else
> done
> fi
>
> -for target in $target_list; do
> - # if a deprecated target is enabled we note it here
> - if echo "$deprecated_targets_list" | grep -q "$target"; then
> - add_to deprecated_features $target
> - fi
> -done
> -
> # see if system emulation was really requested
> case " $target_list " in
> *"-softmmu "*) softmmu=yes
> @@ -4017,12 +3996,6 @@ else
> fi
> fi
>
> -if test -n "${deprecated_features}"; then
> - echo "Warning, deprecated features enabled."
> - echo "Please see docs/about/deprecated.rst"
> - echo " features: ${deprecated_features}"
> -fi
> -