Re: [PATCH v4 15/18] tests/docker: updates to alpine package list

[Daniel P . Berrangé]

On Wed, Dec 15, 2021 at 12:31:33PM +0100, Philippe Mathieu-Daudé wrote:
> On 11/24/21 14:01, Daniel P. Berrangé wrote:
> > Cleanup the package lists by removing some entries that we don't need to
> > directly reference
> > 
> >   binutils: implied by the compiler toolchain
> >   coreutils: not required by QEMU build
> >   mesa-egl mesa-gbm: implied by mesa-dev
> >   ninja: alias for samurai package
> 
> I'd rather keep the alias to avoid looking for ninja or
> for what samurai is. Anyhow,

This change was done to align with the package lists that
lcitool will generate. In lcitool we always aim to use the
canonical package name, rather than any alias, so it is
explicit what impl we're using for something.

> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> >   shadow: not required by QEMU build
> >   util-linux-dev: not directly required by QEMU build
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >  tests/docker/dockerfiles/alpine.docker | 8 +-------
> >  1 file changed, 1 insertion(+), 7 deletions(-)
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|