[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 08/14] vfio-user: handle PCI config space accesses
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [PATCH v4 08/14] vfio-user: handle PCI config space accesses |
|
Date: |
Thu, 16 Dec 2021 16:00:48 +0000 |
On Thu, Dec 16, 2021 at 11:47:40AM +0000, John Levon wrote:
> On Thu, Dec 16, 2021 at 11:30:20AM +0000, Stefan Hajnoczi wrote:
>
> > > + ret = vfu_setup_region(o->vfu_ctx, VFU_PCI_DEV_CFG_REGION_IDX,
> > > + pci_config_size(o->pci_dev),
> > > &vfu_object_cfg_access,
> > > + VFU_REGION_FLAG_RW |
> > > VFU_REGION_FLAG_ALWAYS_CB,
> > > + NULL, 0, -1, 0);
> >
> > Thanos or John: QEMU's pci_host_config_read/write_common() works with
> > host-endian values. I don't know which endianness libvfio-user's region
> > callbacks expect. Does this patch look endian-safe to you (e.g. will it
> > work on a big-endian host)?
>
> https://github.com/nutanix/libvfio-user/issues/615
Thanks!
Stefan
signature.asc
Description: PGP signature
- Re: [PATCH v4 06/14] vfio-user: find and init PCI device, (continued)
[PATCH v4 08/14] vfio-user: handle PCI config space accesses, Jagannathan Raman, 2021/12/15
[PATCH v4 09/14] vfio-user: handle DMA mappings, Jagannathan Raman, 2021/12/15
[PATCH v4 10/14] vfio-user: handle PCI BAR accesses, Jagannathan Raman, 2021/12/15
[PATCH v4 11/14] vfio-user: IOMMU support for remote device, Jagannathan Raman, 2021/12/15