qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL v2 000/101] ppc queue


From: Cédric Le Goater
Subject: Re: [PULL v2 000/101] ppc queue
Date: Fri, 17 Dec 2021 18:31:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0

On 12/17/21 18:24, Richard Henderson wrote:
On 12/17/21 8:46 AM, Cédric Le Goater wrote:
On 12/17/21 17:33, Richard Henderson wrote:
Different docs failure:

Warning, treated as error:
/tmp/qemu-test/src/docs/system/ppc/pseries.rst:241:Unexpected indentation.

You can test this yourself with

make docker-test-build@ubuntu1804 TARGET_LIST=i386-softmmu

hmm, I will be more careful with documentation patches in the future.

How should I send a v3 without resending all patches ?

 From the question, I assume you're using git publish... I'm not sure how to do 
so directly with that tool.

no. I am using the make-pullreq script from Peter which does all the work
to generate the emails and also prepares the git branch for you to pull.

I think I found the last problem and the only change is :

$ git diff ppc-next ppc-7.0
diff --git a/docs/system/ppc/pseries.rst b/docs/system/ppc/pseries.rst
index 72e315eff628..56f5942e13f6 100644
--- a/docs/system/ppc/pseries.rst
+++ b/docs/system/ppc/pseries.rst
@@ -235,4 +235,4 @@ Maintainer contact information
Cédric Le Goater <clg@kaod.org> -Daniel Henrique Barboza <danielhb413@gmail.com>
+Daniel Henrique Barboza <danielhb413@gmail.com>
\ No newline at end of file


Maybe you can generate the email text with --inspect-emails, and then send only 
the cover letter manually with git send-email.

That's what I wanted to do: only send the cover letter. Is that ok ?

Thanks,

C.



The by-hand process is

   git format-patch --subject-prefix=PULL --cover-letter master
   git request-pull master <url> <tag> >> 0000-*
   <edit cover-letter>
   git send-email --to=... --cc=... 0000-*


r~




reply via email to

[Prev in Thread] Current Thread [Next in Thread]