Re: [PATCH 7/8] configure, meson: move config-poison.h to meson

[Richard Henderson]

On 12/21/21 3:05 AM, Paolo Bonzini wrote:
> +genh += custom_target('config-poison.h',
> +                      input: [target_configs_h],
> +                      output: 'config-poison.h',
> +                      capture: true,
> +                      command: [find_program('scripts/make-config-poison.sh')] 
> +
> +                               (target_configs_h.length() > 0 ? ['@INPUT@'] : 
> []))

Using length + @INPUT@ seems needlessly around the bush.
Perhaps better as

  [find_program...] + target_configs_h

Otherwise it looks ok.


r~