qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 5/8] ppc/ppc405: Rework ppc_40x_timers_init() to use a PowerP


From: Richard Henderson
Subject: Re: [PATCH 5/8] ppc/ppc405: Rework ppc_40x_timers_init() to use a PowerPCCPU
Date: Thu, 23 Dec 2021 13:41:37 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 12/21/21 10:40 PM, Cédric Le Goater wrote:
This is a small cleanup to ease reading.

Signed-off-by: Cédric Le Goater<clg@kaod.org>
---
  hw/ppc/ppc.c | 42 +++++++++++++++++++-----------------------
  1 file changed, 19 insertions(+), 23 deletions(-)

You should mention dropping the comparison vs null as impossible as a result of 
g_malloc0.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]