[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration: Don't return for postcopy_send_discard_bm_ram()
From: |
David Edmondson |
Subject: |
Re: [PATCH] migration: Don't return for postcopy_send_discard_bm_ram() |
Date: |
Tue, 04 Jan 2022 08:39:11 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) |
On Thursday, 2021-12-30 at 17:05:25 +01, Philippe Mathieu-Daudé wrote:
> postcopy_send_discard_bm_ram() always return zero. Since it can't
> fail, simplify and do not return anything.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
> ---
> Based-on: <20211224065000.97572-1-peterx@redhat.com>
> ---
> migration/ram.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/migration/ram.c b/migration/ram.c
> index 5234d1ece11..e241ce98461 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -2433,14 +2433,12 @@ void
> ram_postcopy_migrated_memory_release(MigrationState *ms)
> /**
> * postcopy_send_discard_bm_ram: discard a RAMBlock
> *
> - * Returns zero on success
> - *
> * Callback from postcopy_each_ram_send_discard for each RAMBlock
> *
> * @ms: current migration state
> * @block: RAMBlock to discard
> */
> -static int postcopy_send_discard_bm_ram(MigrationState *ms, RAMBlock *block)
> +static void postcopy_send_discard_bm_ram(MigrationState *ms, RAMBlock *block)
> {
> unsigned long end = block->used_length >> TARGET_PAGE_BITS;
> unsigned long current;
> @@ -2464,8 +2462,6 @@ static int postcopy_send_discard_bm_ram(MigrationState
> *ms, RAMBlock *block)
> postcopy_discard_send_range(ms, one, discard_length);
> current = one + discard_length;
> }
> -
> - return 0;
> }
>
> static void postcopy_chunk_hostpages_pass(MigrationState *ms, RAMBlock
> *block);
dme.
--
Tell me sweet little lies.
- Re: [PATCH] migration: Don't return for postcopy_send_discard_bm_ram(),
David Edmondson <=