[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions
From: |
Igor Mammedov |
Subject: |
Re: [PATCH for-7.0] hw/i386/pc: Add missing property descriptions |
Date: |
Thu, 6 Jan 2022 09:10:17 +0100 |
On Mon, 6 Dec 2021 14:42:55 +0100
Thomas Huth <thuth@redhat.com> wrote:
> When running "qemu-system-x86_64 -M pc,help" I noticed that some
> properties were still missing their description. Add them now so
> that users get at least a slightly better idea what they are all
> about.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/i386/pc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index a2ef40ecbc..837f2bff4e 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1734,15 +1734,23 @@ static void pc_machine_class_init(ObjectClass *oc,
> void *data)
>
> object_class_property_add_bool(oc, PC_MACHINE_SMBUS,
> pc_machine_get_smbus, pc_machine_set_smbus);
> + object_class_property_set_description(oc, PC_MACHINE_SMBUS,
> + "Enable/disable system management bus");
>
> object_class_property_add_bool(oc, PC_MACHINE_SATA,
> pc_machine_get_sata, pc_machine_set_sata);
> + object_class_property_set_description(oc, PC_MACHINE_SATA,
> + "Enable/disable Serial ATA bus");
>
> object_class_property_add_bool(oc, PC_MACHINE_PIT,
> pc_machine_get_pit, pc_machine_set_pit);
> + object_class_property_set_description(oc, PC_MACHINE_PIT,
> + "Enable/disable Intel 8254 programmable interval timer emulation");
>
> object_class_property_add_bool(oc, "hpet",
> pc_machine_get_hpet, pc_machine_set_hpet);
> + object_class_property_set_description(oc, "hpet",
> + "Enable/disable high precision event timer emulation");
>
> object_class_property_add_bool(oc, "default-bus-bypass-iommu",
> pc_machine_get_default_bus_bypass_iommu,