[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] migration: Add canary to VMSTATE_END_OF_LIST
From: |
Peter Xu |
Subject: |
Re: [PATCH] migration: Add canary to VMSTATE_END_OF_LIST |
Date: |
Thu, 13 Jan 2022 09:21:43 +0800 |
On Wed, Jan 12, 2022 at 10:56:07AM +0000, Peter Maydell wrote:
> We could have vmstate_register_with_alias_id() iterate through
> and assert presence of the right terminator (probably only if
> qtest enabled, or some other suitable condition). Then the
> existing tests that do the basic "check we can instantiate every
> device and initialize every board model" would run that code
> and catch most missing terminator cases, I think.
Agreed. How about assert it even without qtest? We do tons of assertion for
programming errors anyway in QEMU.
Thanks,
--
Peter Xu