[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/6] hw/usb/canokey: Add trace events
From: |
Gerd Hoffmann |
Subject: |
Re: [PATCH v2 2/6] hw/usb/canokey: Add trace events |
Date: |
Thu, 13 Jan 2022 10:33:54 +0100 |
On Fri, Jan 07, 2022 at 11:35:13PM +0800, Hongren (Zenithal) Zheng wrote:
> Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
scripts/checkpatch.pl complains:
ERROR: line over 90 characters
#112: FILE: hw/usb/canokey.c:209:
+ trace_canokey_handle_data_out_err(ep_out, p->iov.size,
key->ep_out_size[ep_out]);
ERROR: Hex numbers must be prefixed with '0x'
#157: FILE: hw/usb/trace-events:357:
+canokey_handle_control_setup(int request, int value, int index, int length)
"request %04X value %04X index %04X length %04X"
total: 2 errors, 0 warnings, 130 lines checked
take care,
Gerd
- [PATCH v2 0/6] Introduce CanoKey QEMU, Hongren (Zenithal) Zheng, 2022/01/07
- [PATCH v2 4/6] docs: Add CanoKey documentation, Hongren (Zenithal) Zheng, 2022/01/07
- [PATCH v2 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples, Hongren (Zenithal) Zheng, 2022/01/07
- [PATCH v2 6/6] MAINTAINERS: add myself as CanoKey maintainer, Hongren (Zenithal) Zheng, 2022/01/07
- [PATCH v2 1/6] hw/usb: Add CanoKey Implementation, Hongren (Zenithal) Zheng, 2022/01/07
- [PATCH v2 3/6] meson: Add CanoKey, Hongren (Zenithal) Zheng, 2022/01/07
- [PATCH v2 2/6] hw/usb/canokey: Add trace events, Hongren (Zenithal) Zheng, 2022/01/07
- Re: [PATCH v2 2/6] hw/usb/canokey: Add trace events,
Gerd Hoffmann <=