qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL v2 21/36] backends: move dbus-vmstate1.xml to backends/


From: Peter Maydell
Subject: Re: [PULL v2 21/36] backends: move dbus-vmstate1.xml to backends/
Date: Thu, 13 Jan 2022 15:24:27 +0000

On Tue, 21 Dec 2021 at 07:04, <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Although not used by the backend itself, use a common location for
> documentation and sharing purposes.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  {tests/qtest => backends}/dbus-vmstate1.xml | 0
>  tests/qtest/meson.build                     | 2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  rename {tests/qtest => backends}/dbus-vmstate1.xml (100%)
>
> diff --git a/tests/qtest/dbus-vmstate1.xml b/backends/dbus-vmstate1.xml
> similarity index 100%
> rename from tests/qtest/dbus-vmstate1.xml
> rename to backends/dbus-vmstate1.xml
> diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> index ebeac59b3f95..913e987409d5 100644
> --- a/tests/qtest/meson.build
> +++ b/tests/qtest/meson.build
> @@ -98,7 +98,7 @@ if dbus_daemon.found() and 
> config_host.has_key('GDBUS_CODEGEN')
>    #qtests_i386 += ['dbus-vmstate-test']
>    dbus_vmstate1 = custom_target('dbus-vmstate description',
>                                  output: ['dbus-vmstate1.h', 
> 'dbus-vmstate1.c'],
> -                                input: files('dbus-vmstate1.xml'),
> +                                input: meson.source_root() / 
> 'backends/dbus-vmstate1.xml',
>                                  command: [config_host['GDBUS_CODEGEN'],
>                                            '@INPUT@',
>                                            '--interface-prefix', 'org.qemu',

This use of meson.source_root() makes meson complain:

WARNING: Project targeting '>=0.58.2' but tried to use feature
deprecated since '0.56.0': meson.source_root. use
meson.project_source_root() or meson.global_source_root() instead.
[...]
WARNING: Deprecated features used:
 * 0.56.0: {'meson.source_root'}

I'm not sure which of the two suggested replacements is correct here,
but could you find out and send a patch, please ?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]