|
From: | Paolo Bonzini |
Subject: | Re: [PATCH v3 3/3] meson: generate trace events for qmp commands |
Date: | Tue, 18 Jan 2022 13:21:28 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 |
On 1/18/22 11:30, Markus Armbruster wrote:
+# Please keep ordering between 'qapi' and 'trace' subdirs: +# We should first handle 'qapi' subdir, so that all +# generated trace events be generated prior handling 'trace' +# subdir.I naively expect explicit dependencies to be used for ordering, but I'm a Meson noob. I'd like an ACK from a non-noob on this one.
The Make-time dependencies are just fine, but still the Meson language is imperative (with generally immutable objects in order to avoid aliasing horrors) and variables in Meson are all of the ":=" kind; there's no equivalent for Make's "=". So you have to do
subdir('qapi') subdir('trace') in this order so that the variables defined by qapi/ are found in trace/. Acked-by: Paolo Bonzini <pbonzini@redhat.com> but I would replace the comment with: # NOTE: the trace/ subdirectory needs the qapi_trace_events variable # that is filled in by qapi/. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |