[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 5/6] docs/system/devices/usb: Add CanoKey to USB devices e
From: |
Hongren (Zenithal) Zheng |
Subject: |
Re: [PATCH v3 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples |
Date: |
Thu, 20 Jan 2022 10:40:18 +0800 |
On Tue, Jan 18, 2022 at 10:28:49AM +0100, Thomas Huth wrote:
> On 13/01/2022 19.11, Hongren (Zenithal) Zheng wrote:
> > Signed-off-by: Hongren (Zenithal) Zheng <i@zenithal.me>
> > ---
> > docs/system/devices/usb.rst | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/docs/system/devices/usb.rst b/docs/system/devices/usb.rst
> > index afb7d6c226..341694403a 100644
> > --- a/docs/system/devices/usb.rst
> > +++ b/docs/system/devices/usb.rst
> > @@ -199,6 +199,9 @@ option or the ``device_add`` monitor command. Available
> > devices are:
> > ``u2f-{emulated,passthru}``
> > Universal Second Factor device
> > +``canokey``
> > + An Open-source Secure Key implementing FIDO2, OpenPGP, PIV and more.
>
> Reviewed-by: Thomas Huth <thuth@redhat.com>
>
> Just an additional idea: It might be helpful for the users if you put a link
> to the separate documentation from the previous patch here?
Will be added in the next version.
>
> Thomas
>
- [PATCH v3 0/6] Introduce CanoKey QEMU, Hongren (Zenithal) Zheng, 2022/01/13
- [PATCH v3 1/6] hw/usb: Add CanoKey Implementation, Hongren (Zenithal) Zheng, 2022/01/13
- [PATCH v3 2/6] hw/usb/canokey: Add trace events, Hongren (Zenithal) Zheng, 2022/01/13
- [PATCH v3 3/6] meson: Add CanoKey, Hongren (Zenithal) Zheng, 2022/01/13
- [PATCH v3 4/6] docs: Add CanoKey documentation, Hongren (Zenithal) Zheng, 2022/01/13
- [PATCH v3 5/6] docs/system/devices/usb: Add CanoKey to USB devices examples, Hongren (Zenithal) Zheng, 2022/01/13
- [PATCH v3 6/6] MAINTAINERS: add myself as CanoKey maintainer, Hongren (Zenithal) Zheng, 2022/01/13