Re: [PATCH] Add --with-branding-prefix and QEMU_BRANDING_PREFIX

[Liviu Ionescu]

> On 20 Jan 2022, at 13:35, Liviu Ionescu <ilg@livius.net> wrote:
> 
> It is usual for various distributions to identify themselves by
> prepending a string to the greeting message, for example
> 'xPack QEMU emulator version 6.2.0 (v6.2.0-2-xpack-arm)'.
> 
> To achieve this, a new configuration option (--with-branding-prefix=)
> was added, which, if not empty, adds a string preprocessor macro
> (QEMU_BRANDING_PREFIX) to 'config-host.h'.
> 
> If this macro is defined, in QEMU and various tools, the string
> is displayed before the existing greeting messages.

This proposal uses a conservative approach, and does not assume that the macro 
is always defined.

However, unless the configure process fails for an obscure reason to add 
QEMU_BRANDING_PREFIX to config-host.h, the definition should be always present; 
in this case the code using this definition can be simplified, by removing the 
#if/#endif and always inserting QEMU_BRANDING_PREFIX at the beginning of the 
string.

Any feedback will be appreciated!


Liviu