[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 27/38] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() re
From: |
Peter Maydell |
Subject: |
[PULL 27/38] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value |
Date: |
Thu, 20 Jan 2022 12:36:19 +0000 |
process_its_cmd() returns a bool, like all the other process_ functions.
However we were putting its return value into 'res', not 'result',
which meant we would ignore it when deciding whether to continue
or stall the command queue. Fix the typo.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20220111171048.3545974-4-peter.maydell@linaro.org
---
hw/intc/arm_gicv3_its.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/intc/arm_gicv3_its.c b/hw/intc/arm_gicv3_its.c
index 5919b1a3b7f..a6c2299a091 100644
--- a/hw/intc/arm_gicv3_its.c
+++ b/hw/intc/arm_gicv3_its.c
@@ -678,10 +678,10 @@ static void process_cmdq(GICv3ITSState *s)
switch (cmd) {
case GITS_CMD_INT:
- res = process_its_cmd(s, data, cq_offset, INTERRUPT);
+ result = process_its_cmd(s, data, cq_offset, INTERRUPT);
break;
case GITS_CMD_CLEAR:
- res = process_its_cmd(s, data, cq_offset, CLEAR);
+ result = process_its_cmd(s, data, cq_offset, CLEAR);
break;
case GITS_CMD_SYNC:
/*
--
2.25.1
- [PULL 13/38] hw/arm/virt: Support for virtio-mem-pci, (continued)
- [PULL 13/38] hw/arm/virt: Support for virtio-mem-pci, Peter Maydell, 2022/01/20
- [PULL 10/38] tests/acpi/bios-table-test: Update expected virt/PPTT file, Peter Maydell, 2022/01/20
- [PULL 11/38] docs/can: convert to restructuredText, Peter Maydell, 2022/01/20
- [PULL 15/38] hw/intc/arm_gic: Allow reset of the running priority, Peter Maydell, 2022/01/20
- [PULL 21/38] hw/arm/virt: Drop superfluous checks against highmem, Peter Maydell, 2022/01/20
- [PULL 24/38] hw/arm/aspeed: Add the i3c device to the AST2600 SoC, Peter Maydell, 2022/01/20
- [PULL 36/38] hw/intc/arm_gicv3_its: Check indexes before use, not after, Peter Maydell, 2022/01/20
- [PULL 28/38] hw/intc/arm_gicv3_its: Don't use data if reading command failed, Peter Maydell, 2022/01/20
- [PULL 30/38] hw/intc/arm_gicv3_its: Fix return codes in process_its_cmd(), Peter Maydell, 2022/01/20
- [PULL 19/38] hw/arm/virt: Use the PA range to compute the memory map, Peter Maydell, 2022/01/20
- [PULL 27/38] hw/intc/arm_gicv3_its: Fix handling of process_its_cmd() return value,
Peter Maydell <=
- [PULL 25/38] hw/intc/arm_gicv3_its: Fix event ID bounds checks, Peter Maydell, 2022/01/20
- [PULL 26/38] hw/intc/arm_gicv3_its: Convert int ID check to num_intids convention, Peter Maydell, 2022/01/20
- [PULL 32/38] hw/intc/arm_gicv3_its: Fix return codes in process_mapti(), Peter Maydell, 2022/01/20
- [PULL 33/38] hw/intc/arm_gicv3_its: Fix return codes in process_mapc(), Peter Maydell, 2022/01/20
- [PULL 37/38] hw/intc/arm_gicv3_its: Range-check ICID before indexing into collection table, Peter Maydell, 2022/01/20
- [PULL 38/38] hw/intc/arm_gicv3: Check for !MEMTX_OK instead of MEMTX_ERROR, Peter Maydell, 2022/01/20