[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/arm: Allow only specific instructions based on the SC
From: |
Idan Horowitz |
Subject: |
Re: [PATCH] target/arm: Allow only specific instructions based on the SCTLR_EL1.UCI bit |
Date: |
Thu, 20 Jan 2022 15:24:52 +0200 |
On Thu, 20 Jan 2022 at 14:32, Peter Maydell <peter.maydell@linaro.org> wrote:
>
>
> But the code you are effectively removing is never executed
> for the instructions where you're changing the access function.
> If you're proposing this as a performance improvement, can
> you provide before-and-after benchmarks demonstrating that
> improvement ?
>
I wanted to say that in my micro-benchmark of DC IVAC I saw a 1%
decrease in runtime, but I failed to replicate it again now, so I must
have accidentally ran it together with one of my other patches last
time.
Sorry for wasting your time with the review.
>
> thanks
> -- PMM
Regards,
Idan Horowitz