[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 3/3] meson: generate trace events for qmp commands
|
From: |
John Snow |
|
Subject: |
Re: [PATCH v4 3/3] meson: generate trace events for qmp commands |
|
Date: |
Fri, 21 Jan 2022 12:59:15 -0500 |
On Fri, Jan 21, 2022 at 11:23 AM Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com> wrote:
>
> 1. Add --no-trace-events to suppress trace events generation in some
> cases, and make trace events be generated by default.
> 2. Add corresponding .trace-events files as outputs in qapi_files
> custom target
> 3. Define global qapi_trace_events list of .trace-events file targets,
> to fill in trace/qapi.build and to use in trace/meson.build
> 4. In trace/meson.build use the new array as an additional source of
> .trace_events files to be processed
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
patch 2 and 3 come out clean under the kinda-sorta-linting I've been doing:
Acked-by: John Snow <jsnow@redhat.com>
(No time to do a bigger review, I'm drowning in backlog ... you and
Markus know where to find me if you need something urgently, though.)